fix: do not return partial matches for threshold 0#766
fix: do not return partial matches for threshold 0#766RomanHotsiy wants to merge 1 commit intokrisk:mainfrom
Conversation
|
Hey @krisk 🙌 Thanks for the great lib! I hit one problem and noticed it was already reported #762 so I decided to fix it. The fix is one-liner and I added a unit test to cover it. Please, let me know if you want me to adjust something or if you feel this is not a good fit in general (so I will maintain a fork or implement a workaround on top). Thanks in advance! |
|
@krisk Are there any plans to merge this? The project I'm working on is affected by this problem too. |
|
Having the same issue and this PR fixes it, if changed locally in my node_modules. Would be great, if this could be merged. Although to my understanding there could be still multiple indices returned as in my case, where I have a very long string that can contain the exact string match multiple times. So, the test of this PR could be updated to reflect that. |
|
encountered the same issue. Is there a chance to re-open this PR? |
Fixes #762